Watch, Follow, &
Connect with Us

QualityCentral

Public Report
Report From: Delphi-BCB/IDE/Search/Replace    [ Add a report in this area ]  
Report #:  2624   Status: Reported
Popup a messagebox at the end of a 'Replace all' and display how many replaces occured
Project:  Delphi Build #:  6.0.6.240
Version:    6.0 Submitted By:   Christophe Lach
Report Type:  Suggestion / Enhancement Request Date Reported:  10/9/2002 8:21:43 AM
Severity:    Infrequently encountered problem Last Updated: 1/8/2008 3:31:53 PM
Platform:    All platforms Internal Tracking #:  
Resolution: None  Resolved in Build: : None
Duplicate of:  None
Voting and Rating
Overall Rating: (8 Total Ratings)
3.75 out of 5
Total Votes: 1
Description
The current Search & replace is silent.
Add a messagebox to display how many replaces occured when 'replace all' is checked.

Make this feature optionnal with a checkbox
called 'show replace summary'
in the environment options.
Steps to Reproduce:
A silent replace function can be very dansgerous when the F3 key is pressed by error.
For example :

Assuming you want to replace all 0 by 1 in a three lines formula.

You select 3 lines of code containing formulas and replace all 0 with 1 on those 3 lines of code (with option 'in selected text only' and 'replace all' checked)

After doing this hit F3 'by error' ... the ide replaces 'silently' every 0 by 1 in the whole source.
Now just save, compile and send to customer. :-(


Of course this will happen at the end of the day. When you're tyred and have
modified the biggest unit of your application the whole day. <g>
Workarounds
None
Attachment
None
Comments

Brian Cook at 10/9/2002 2:16:15 PM -

To Borland: If this feature is added, PLEASE provide an option to turn it off.

I can certainly understand why this is important to others but I would find this feature very annoying.  I have to ingore way too many popups now!

Christophe Lach at 10/10/2002 5:39:20 AM -
Hello,

I agree, some people may no want it.
I've added your suggestion to the description.

Regards
chris

Ritsaert Hornstra at 10/10/2002 4:00:44 AM -
Another way is that in the Messages pane, the amount of replaces is shown (less intrusive!)

Christophe Lach at 10/10/2002 5:48:28 AM -
hello,

The status panel is not a bad idea,
But i would really like a feature that warns me.

look into steps what happened to me.
I did not send the app to the customer... ok
but i saved without noticing what F3 did ...
It was my mistake to press F3 ok, but it was a big hassle to put everything back in place,
when i reopened the source after understanding something was wrong.

With a summary messagebox this could not happen.

Ok i'm asking the IDE to help me. But isn't the IDE just here for that purpose ?
If he is not we could use EDLIN or VI <g>

Kristofer Skaug at 10/10/2002 8:02:23 AM -
I see your point (the example) - but I would say this behaviour from Delphi's side is incorrect or at least very dangerous (as you say).
A "Replace All" operation should definitely not be repeatable on a different scope of code by just hitting F3.
The function F3 is after all called "Search Again", not "Replace Again"...
So I'd suggest you either
a) change the suggestion to concern blocking this behaviour for "Replace" operations, rather than to notify about it, or
b) specify that the messagebox appear only for using F3 in the context of "Replace All" rather than all "Replace All" operations (also those initiated with Ctrl+R and dialogue).

Christophe Lach at 10/11/2002 3:03:15 AM -
>I see your point (the example) - but I would say this behaviour from Delphi's side is incorrect or at least very
>dangerous (as you say).
>A "Replace All" operation should definitely not be repeatable on a different scope of code by just hitting F3.

Yes, i agree. If F3 repeats the last action it should not forget that 'in selection only' was checked before !
But posting in the IDE forum i just got the answer 'This was like this since delphi 1 so no need to change now'
Surprising no ?

>The function F3 is after all called "Search Again", not "Replace Again"...

I don't know for the english version. Do you have an english one ? can you confirm this ?
Well in the French delphi 5 & 6 it's called 'Occurence suivante' who will traduce to 'Next item'.
Funny no ?

>So I'd suggest you either
>a) change the suggestion to concern blocking this behaviour for "Replace" operations,
>rather than to notify about it, or
>b) specify that the messagebox appear only for using F3 in the context of "Replace All"
>rather than all "Replace All" operations (also those initiated with Ctrl+R and dialogue).

Good point .. my idea was b) but i forgot to mention 'replace all' i'll update the description. Thanks a lot.

A good  think would be to correct F3 not to forget the previous 'in selection only'
But as said i was told 'this has always been so, won't do'

And as Joe said QC 2122 already exists but was rated horribly just because the one who wrote the description did it in an 'horrible' english (english was probably not his native language).
Personnaly i cannot accept nor understand this 'binary' (what's not perfect is false) way of thinking.

Joe White at 10/10/2002 11:48:50 AM -
That's already been done.  See report #2122.

What baffles me is why #2122 has gotten such poor ratings - it seems pretty obvious to *me* that having F3 be able to do a Replace All, without any warnings or confirmations, is a Very Bad Thing.

If you think F3 shouldn't repeat a Replace All, head over to #2122 and give it some good ratings and votes.

Christophe Lach at 10/11/2002 2:56:54 AM -
>What baffles me is why #2122 has gotten such poor ratings - it seems pretty obvious to *me* that
>having F3 be able to do a Replace All, without any warnings or confirmations, is a Very Bad Thing.
>If you think F3 shouldn't repeat a Replace All, head over to #2122 and give it some good ratings and votes.

I was stunned too.

I think it's too late for QC 2122. The author will never come back and update his description. He has too many bad ratings.

The problem is QC 2122 is badly written. 2122 speaks of 'in selected box' instead of 'in selection only'
See my comment there.

I think we need someone courageous to post a rephrased duplicate of 2122... in perfect english ;)

I'll support you if you do so.

Server Response from: ETNACODE01

Copyright© 1994 - 2013 Embarcadero Technologies, Inc. All rights reserved.